netdev - Re: [PATCH] net: remove rcu locking from fib_rules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1268807559.2932.35.camel@edumazet-laptop>
Date:	Wed, 17 Mar 2010 07:32:39 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, paulmck@...ux.vnet.ibm.com
Subject: Re: [PATCH] net: remove rcu locking from fib_rules_event()

Le mardi 16 mars 2010 à 21:28 -0700, David Miller a écrit :
> From: Eric Dumazet <eric.dumazet@...il.com>
> Date: Wed, 10 Mar 2010 07:03:38 +0100
> 
> > We hold RTNL at this point and dont use RCU variants of list traversals,
> > we dont need rcu_read_lock()/rcu_read_unlock()
> > 
> > Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> 
> Applied.

Thanks David.

I believe the synchronize_rcu() we have in this file is useless too,
I'll submit a patch.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html