| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 17 Mar 2010 23:40:38 +1100 From: Darren Jenkins <darrenrjenkins@...il.com> To: David Miller <davem@...emloft.net> Cc: inaky.perez-gonzalez@...el.com, linux-wimax@...el.com, kernel-janitors@...r.kernel.org, cindy.h.kao@...el.com, dirk.j.brandewie@...el.com, wimax@...uxwimax.org, netdev@...r.kernel.org, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] drivers/net/wimax/i2400m/fw.c fix possible double free On Wed, Mar 17, 2010 at 8:14 AM, David Miller <davem@...emloft.net> wrote: > Therefore the krealloc() failure handling in this driver should NULL > out i2400m->fw_hdrs and that will fix the double kfree problem as well > as trap any stray references. Yes that is a much better Idea. Thanks for the advice. It also fixes the i2400m_barker_db problem that I didn't notice before. Fix double free on krealloc() failure by zeroing pointer coverity CID: 13455 Signed-off-by: Darren Jenkins <darrenrjenkins@...il.com> --- drivers/net/wimax/i2400m/fw.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/wimax/i2400m/fw.c b/drivers/net/wimax/i2400m/fw.c index 25c24f0..9f3b594 100644 --- a/drivers/net/wimax/i2400m/fw.c +++ b/drivers/net/wimax/i2400m/fw.c @@ -232,8 +232,9 @@ int i2400m_zrealloc_2x(void **ptr, size_t *_count, size_t el_size, *_count = new_count; *ptr = nptr; return 0; - } else - return -ENOMEM; + } + *ptr = NULL; + return -ENOMEM; } -- 1.6.3.3 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists