netdev - Re: [PATCH 6/9] ipv6: addrconf timer changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1268897863.10592.38.camel@cirrhata.linux-ipv6.org>
Date:	Thu, 18 Mar 2010 16:37:43 +0900
From:	YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH 6/9] ipv6: addrconf timer changes

Hello.

Stephen Hemminger wrote:

> For addrconf timer use round_jiffies to round off to next interval
> (rather than manual rounding).
> 
> Signed-off-by: Stephen Hemminger <shemminger@...tta.com>
> 
> 
> ---
>  net/ipv6/addrconf.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/net/ipv6/addrconf.c	2010-03-15 16:10:25.069213714 -0700
> +++ b/net/ipv6/addrconf.c	2010-03-15 16:10:25.709836446 -0700
> @@ -3194,7 +3194,7 @@ restart:
>  		}
>  	}
>  
> -	addr_chk_timer.expires = time_before(next, jiffies + HZ) ? jiffies + HZ : next;
> +	addr_chk_timer.expires = round_jiffies(next);
>  	add_timer(&addr_chk_timer);
>  	spin_unlock(&addrconf_verify_lock);
>  	rcu_read_unlock_bh();
> 

I'd like to NAK this.

This could round down, but in this routine, the time
is checked.  If the time is not yet, no process and reschedule
happens again.  So, I don't think it is useful.

Well,
   addr_chk_timer.expires = next + HZ;
or
   addr_chk_timer.expires = jiffies_round_up(next);

could be an answer, but it is too lazy and not acceptable for me.
(Well, I don't need 100Hz but I want to have 3-10Hz at least.)

I'll make an alternative patch.

Regards,

--yoshfuji

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html