netdev - Re: [Patch] netpoll: warn when there are spaces in parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4BA189BD.7070400@redhat.com>
Date:	Thu, 18 Mar 2010 10:02:37 +0800
From:	Cong Wang <amwang@...hat.com>
To:	Frans Pop <elendil@...net.nl>
CC:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	davem@...emloft.net
Subject: Re: [Patch] netpoll: warn when there are spaces in parameters

Frans Pop wrote:
> Amerigo Wang wrote:
>> +               if (*cur == ' ' || *cur == '\t')
>> +                       printk(KERN_INFO "%s: warning: white spaces"
>> +                                       "are not allowed.\n", np->name);
>>
> 
> The term "white spaces" not correct. Please change the message to
> "whitespace is not allowed".
> 
> Also, it's normally not necessary to close kernel messages with a period; 
> most kernel messages do not have a closing period. Messages are not 
> sentences and the periods only help increase the kernel size.
> 

Ok, I will update it.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html