netdev - Re: [PATCH 1/3] netlink: fix NETLINK_RECV_NO_ENOBUFS in netlink_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100320.143027.116368032.davem@davemloft.net>
Date:	Sat, 20 Mar 2010 14:30:27 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	pablo@...filter.org
Cc:	kaber@...sh.net, netdev@...r.kernel.org
Subject: Re: [PATCH 1/3] netlink: fix NETLINK_RECV_NO_ENOBUFS in
 netlink_set_err()

From: Pablo Neira Ayuso <pablo@...filter.org>
Date: Fri, 19 Mar 2010 01:24:42 +0100

> Patrick McHardy wrote:
>> Generally the logic seems inverted, you should return an error
>> to conntrack if userspace wasn't notified of the error.
> 
> Indeed, thanks. Are you OK with this patch instead?

I went over all of this and now the patches #1 and #2 look
correct to me, so I've applied them to net-2.6

Patrick let me know if you think any follow-on tidy ups
are still necessary and we can add them.

Thanks Pablo!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html