[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20100319.210611.71090762.davem@davemloft.net>
Date: Fri, 19 Mar 2010 21:06:11 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: jeffrey.t.kirsher@...el.com
Cc: netdev@...r.kernel.org, gospo@...hat.com, gregory.v.rose@...el.com
Subject: Re: [net-2.6 PATCH 1/3] ixgbevf: Fix VF Stats accounting after
reset
From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Fri, 19 Mar 2010 05:59:52 -0700
> From: Greg Rose <gregory.v.rose@...el.com>
>
> The counters in the 82599 Virtual Function are not clear on read. They
> accumulate to the maximum value and then roll over. They are also not
> cleared when the VF executes a soft reset, so it is possible they are
> non-zero when the driver loads and starts. This has all been accounted
> for in the code that keeps the stats up to date but there is one case
> that is not. When the PF driver is reset the counters in the VF are
> all reset to zero. This adds an additional accounting overhead into
> the VF driver when the PF is reset under its feet. This patch adds
> additional counters that are used by the VF driver to accumulate and
> save stats after a PF reset has been detected. Prior to this patch
> displaying the stats in the VF after the PF has reset would show
> bogus data.
>
> Signed-off-by: Greg Rose <gregory.v.rose@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists