netdev - RE: [PATCH] netdev: don't always reset iflink when registering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 22 Mar 2010 12:06:46 -0700
From:	"Goff, Thomas" <Thomas.Goff@...ing.com>
To:	Patrick McHardy <kaber@...sh.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH] netdev: don't always reset iflink when registering

From: Patrick McHardy <mailto:kaber@...sh.net>
Sent: Monday, March 22, 2010 10:43 AM
> 
> Tom Goff wrote:
> > Bound tunnel devices set their iflink to the ifindex of the 
> underlying
> > network interface when created.  It shouldn't be reset by the
> > registration process.
> >   
> 
> Which ones exactly? Usually they do this in ->setup() or later on.

I observed the issue with a bound gre tunnel where:

	ipgre_newlink()
		...
		ipgre_tunnel_bind_dev()	/* set dev->iflink */
		...
		register_netdevice()	/* reset dev->iflink */

There's a similar pattern in ipv6/sit.c:

	ipip6_tunnel_locate()
		...
		ipip6_tunnel_init()
			...
			ipip6_tunnel_bind_dev()	/* set dev->iflink */
		...
		register_netdevice()		/* reset dev->iflink */

So maybe it makes more sense to change these if that's more consistent
with other cases.

Thanks for looking at this and the tc stuff.

  Tom
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html