netdev - Re: [PATCH] netlink: use the appropriate namespace pid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100322.202526.141239221.davem@davemloft.net>
Date:	Mon, 22 Mar 2010 20:25:26 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	thomas.goff@...ing.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] netlink: use the appropriate namespace pid

From: Tom Goff <thomas.goff@...ing.com>
Date: Fri, 19 Mar 2010 18:38:50 -0700

> This was included in OpenVZ kernels but wasn't integrated upstream.
>>>From git://git.openvz.org/pub/linux-2.6.24-openvz:
> 
> 	commit 5c69402f18adf7276352e051ece2cf31feefab02
> 	Author: Alexey Dobriyan <adobriyan@...nvz.org>
> 	Date:   Mon Dec 24 14:37:45 2007 +0300
> 
> 	    netlink: fixup ->tgid to work in multiple PID namespaces
> 
> Signed-off-by: Tom Goff <thomas.goff@...ing.com>

BTW, we're ok without this.

The 'pid' in this code is just an arbitrary port number.  We are
merely using the tgid to seed the port allocator, so it doesn't have
to be the real proper tgid.

I'm therefore dropping this for now.  If Alexey can show why we
might need this, we can revisit the patch.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html