[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20100322.215936.113720990.davem@davemloft.net>
Date: Mon, 22 Mar 2010 21:59:36 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: mpm@...enic.com
Cc: amwang@...hat.com, linux-kernel@...r.kernel.org,
netdev@...r.kernel.org, bridge@...ts.linux-foundation.org,
gospo@...hat.com, nhorman@...driver.com,
shemminger@...ux-foundation.org,
bonding-devel@...ts.sourceforge.net, fubar@...ibm.com
Subject: Re: [RFC Patch 2/3] bridge: make bridge support netpoll
From: Matt Mackall <mpm@...enic.com>
Date: Mon, 22 Mar 2010 23:51:01 -0500
> On Tue, 2010-03-23 at 12:39 +0800, Cong Wang wrote:
>> Matt Mackall wrote:
>> How could you let the bridge know netpoll is not sent to
>> the one that doesn't support netpoll during setup? This will
>> be complex, I am afraid.
>
> I thought I saw a simple loop over bridge devices at poll time in your
> patch. So it should be a simple matter of skipping unsupported devices
> in that loop.
It's because of all that "assign ->npinfo to slaves" crap he has to do
the way his patches are currently implemented.
It's basically another sign that the design is wrong.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists