netdev - Re: [patch] wimax: remove unneeded variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100324.133656.200772463.davem@davemloft.net>
Date:	Wed, 24 Mar 2010 13:36:56 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	error27@...il.com
Cc:	netdev@...r.kernel.org, andre.goddard@...il.com,
	adobriyan@...il.com, jkosina@...e.cz,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch] wimax: remove unneeded variable

From: Dan Carpenter <error27@...il.com>
Date: Wed, 24 Mar 2010 14:56:03 +0300

> We never actually use "dev" so I removed it.
> 
> Signed-off-by: Dan Carpenter <error27@...il.com>

I think the intention was to pass it into to these
stupid function call tracing debugging macros the
WIMAX stuff has.  It's passing NULL currently.

Anyways, I've applied this, thanks.

But seriously, why is every developer of some new subsystem or driver
inclined to add such ugly debugging infrastructure?  It's seemingly
the first thing they do before writing any code.

I'd very much like to see a patch that removes all of this junk and
"rm -f include/linux/wimax/debug.h"
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html