netdev - Re: [PATCH] skbuff: remove unused dma_head & dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100324.111350.158441178.davem@davemloft.net>
Date:	Wed, 24 Mar 2010 11:13:50 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	jeffrey.t.kirsher@...el.com, netdev@...r.kernel.org,
	gospo@...hat.com, alexander.h.duyck@...el.com
Subject: Re: [PATCH] skbuff: remove unused dma_head & dma_maps fields

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 24 Mar 2010 07:48:06 +0100

> Le mardi 23 mars 2010 à 23:40 -0700, Jeff Kirsher a écrit :
>> From: Alexander Duyck <alexander.h.duyck@...el.com>
>> 
>> The dma map fields in the skb_shared_info structure no longer has any users
>> and can be dropped since it is making the skb_shared_info unecessarily larger.
>> 
>> Running slabtop show that we were using 4K slabs for the skb->head on x86_64 w/
>> an allocation size of 1522.  It turns out that the dma_head and dma_maps array
>> made skb_shared large enough that we had crossed over the 2k boundary with
>> standard frames and as such we were using 4k blocks of memory for all skbs.
>> 
>> Signed-off-by: Alexander Duyck <alexander.h.duyck@...el.com>
>> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
>> ---
>> 
> 
> Thanks a lot for doing this cleanup !
> 
> Acked-by: Eric Dumazet <eric.dumazet@...il.com>

Yep, thanks indeed.  Applied!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html