netdev - Re: [PATCH] e1000e: Use pr_<level> and netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100326.205248.258788303.davem@davemloft.net>
Date:	Fri, 26 Mar 2010 20:52:48 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	joe@...ches.com
Cc:	bruce.w.allan@...el.com, jeffrey.t.kirsher@...el.com,
	netdev@...r.kernel.org, gospo@...hat.com
Subject: Re: [PATCH] e1000e: Use pr_<level> and netdev_<level>

From: Joe Perches <joe@...ches.com>
Date: Wed, 24 Mar 2010 17:04:34 -0700

> hw and adapter are locally scoped in each function here,
> but are not local to the macro.  That can make conversions
> of macros to functions difficult.

This is pretty common practice in drivers though.

Especially for register accessors and whatnot, and I see no problem
doing it here.

All specifying these args explicitly will do is make the fingers move
one step closer to carpel tunnel. :-)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html