netdev - Re: [ANNOUNCEMENT] NET: usb: sierra

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1269791821.11714.202.camel@localhost.localdomain>
Date:	Sun, 28 Mar 2010 08:57:01 -0700
From:	Marcel Holtmann <marcel@...tmann.org>
To:	Elina Pasheva <epasheva@...rrawireless.com>
Cc:	David Brownell <dbrownell@...rs.sourceforge.net>,
	Rory Filer <rfiler@...rrawireless.com>, netdev@...r.kernel.org,
	linux-usb <linux-usb@...r.kernel.org>
Subject: Re: [ANNOUNCEMENT] NET: usb: sierra_net.c driver

Hi Elina,

> +static const struct driver_info sierra_net_info_68A3 = {
> +	.description = "Sierra Wireless USB-Ethernet Modem",
> +	.flags = FLAG_ETHER | FLAG_SEND_ZLP,
> +	.bind = sierra_net_bind,
> +	.unbind = sierra_net_unbind,
> +	.status = sierra_net_status,
> +	.rx_fixup = sierra_net_rx_fixup,
> +	.tx_fixup = sierra_net_tx_fixup,
> +	.data = (unsigned long)&sierra_net_info_data_68A3,
> +};

the FLAG_ETHER is wrong here. Please use FLAG_WWAN to clearly mark these
interfaces.

Otherwise we have wrong DEVTYPE uevent assignments and userspace will
treat them as real Ethernet cards. And that should not happen. As a nice
benefit the interface name will be wwan%d by default as well.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html