lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20100328220416.GB4220@electric-eye.fr.zoreil.com> Date: Mon, 29 Mar 2010 00:04:16 +0200 From: François Romieu <romieu@...zoreil.com> To: David Miller <davem@...emloft.net> Cc: ben@...adent.org.uk, timo.teras@....fi, ivecera@...hat.com, netdev@...r.kernel.org Subject: Re: [PATCH] r8169: fix broken register writes David Miller <davem@...emloft.net> : [...] > Probably the rest of the driver should be audited for other > areas where we may end up having this problem. Those look safe - MAC0 - MAC4 - MAR0 - CounterAddrLow - CounterAddrHigh - TxDescStartAddrLow - TxDescStartAddrHigh - RxDescAddrLow - RxDescAddrHigh The other candidates are not used yet. [...] > 1) Coverage for all possible bug cases. > > 2) Real 64-bit accesses on 64-bit platforms. I see your point but the MACx and MARx registers are nowhere documented as 64 bit : MAC0 and MAC4 (0x00 to 0x07) span IDR[0..5] + two reserved bytes while MARx are documented as MAR[7..0] (0x08 to 0x0f). It would be nice if it happened to work though. -- Ueimor -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists