lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20100327.193815.242127373.davem@davemloft.net> Date: Sat, 27 Mar 2010 19:38:15 -0700 (PDT) From: David Miller <davem@...emloft.net> To: romieu@...zoreil.com Cc: ben@...adent.org.uk, timo.teras@....fi, ivecera@...hat.com, netdev@...r.kernel.org Subject: Re: [PATCH] r8169: fix broken register writes From: François Romieu <romieu@...zoreil.com> Date: Sun, 28 Mar 2010 01:31:43 +0100 > This is quite similar to b39fe41f481d20c201012e4483e76c203802dda7 > though said registers are not even documented as 64-bit registers > - as opposed to the initial TxDescStartAddress ones - but as single > bytes which must be combined into 32 bits at the MMIO read/write > level before being merged into a 64 bit logical entity. > > Credits go to Ben Hutchings <ben@...adent.org.uk> for the MAR > registers (aka "multicast is broken for ages on ARM) and to > Timo Teräs <timo.teras@....fi> for the MAC registers. > > Signed-off-by: Francois Romieu <romieu@...zoreil.com> Applied, thanks Francois. Probably the rest of the driver should be audited for other areas where we may end up having this problem. Or, we should create readq/writeq macros (like other drivers do on 32-bit platforms, f.e. see drivers/net/niu.c) which write the two 32-bit parts in this required order. Then access the registers using readq/writeq entities throughout the driver. This would have two benefits: 1) Coverage for all possible bug cases. 2) Real 64-bit accesses on 64-bit platforms. Just some suggestions. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists