netdev - RE: [net-next-2.6 PATCH 3/8] vxge: Align the memory only if it is misaligned.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <78C9135A3D2ECE4B8162EBDCE82CAD77064C43D7@nekter>
Date:	Mon, 29 Mar 2010 20:04:43 -0400
From:	"Ramkrishna Vepa" <Ramkrishna.Vepa@...r.com>
To:	"David Miller" <davem@...emloft.net>,
	"Sreenivasa Honnur" <Sreenivasa.Honnur@...erion.com>
Cc:	<netdev@...r.kernel.org>, "support" <support@...erion.com>
Subject: RE: [net-next-2.6 PATCH 3/8] vxge: Align the memory only if it is misaligned.

> From: Sreenivasa Honnur <Sreenivasa.Honnur@...erion.com>
> Date: Mon, 29 Mar 2010 04:09:47 -0400 (EDT)
> 
> > - Align the memory only if it is misaligned.
> >
> > Signed-off-by: Sreenivasa Honnur <sreenivasa.honnur@...erion.com>
> > Signed-off-by: Ramkrishna Vepa <ram.vepa@...erion.com>
> 
> Applied, but this vxge_os_dma_malloc code is completely
> unnecessary.
> 
> If you want to allocate 4K chunks and make sure they are at least 128
> byte aligned, you can allocated pages (which are always PAGE_SIZE
> aligned) and chop them up into the appropriate block size as needed.
> 
> This is exactly how drivers/net/niu.c handles this situation.
> 
> See drivers/net/niu.c:niu_rbr_add_page()
Thanks. We'll make this change.

Ram
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html