netdev - Re: [PATCH v3 10/12] l2tp: Add L2TP ethernet pseudowire support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 30 Mar 2010 09:30:09 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	James Chapman <jchapman@...alix.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v3 10/12] l2tp: Add L2TP ethernet pseudowire support

On Tue, 30 Mar 2010 17:18:19 +0100
James Chapman <jchapman@...alix.com> wrote:

> static inline struct l2tp_eth_net *l2tp_eth_pernet(struct net *net)
> +{
> +	BUG_ON(!net);
> +
> +	return net_generic(net, l2tp_eth_net_id);
> +}

Don't test for NULL with BUG_ON. It is redundant, the null
dereference will cause the same kind of backtrace failure.


-- 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html