netdev - Re: [PATCH] net: Fix oops from tcp_collapse() when using splice()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100330.135622.233398574.davem@davemloft.net>
Date:	Tue, 30 Mar 2010 13:56:22 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	steve@...idescorp.com
Cc:	netdev@...r.kernel.org, kuznet@....inr.ac.ru, pekkas@...core.fi,
	jmorris@...ei.org, yoshfuji@...ux-ipv6.org, kaber@...sh.net,
	linux-kernel@...r.kernel.org, monstr@...str.eu, karl@...amoto.org
Subject: Re: [PATCH] net: Fix oops from tcp_collapse() when using splice()

From: David Miller <davem@...emloft.net>
Date: Tue, 30 Mar 2010 13:47:41 -0700 (PDT)

> From: "Steven J. Magnani" <steve@...idescorp.com>
> Date: Tue, 30 Mar 2010 15:45:13 -0500
> 
>> tcp_read_sock() can have a eat skbs without immediately advancing copied_seq.
>> This can cause a panic in tcp_collapse() if it is called as a result
>> of the recv_actor dropping the socket lock.
>> 
>> A userspace program that splices data from a socket to either another
>> socket or to a file can trigger this bug.
>> 
>> Signed-off-by: Steven J. Magnani <steve@...idescorp.com>
> 
> Thanks for fixing this I'll look at your patch more closely
> right now.

Patch applied, thanks Steven!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html