netdev - Re: XT_ALIGN changed to use ALIGN breaks iproute2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b6fcc0a1003300615k54092120nfb8b5378771657@mail.gmail.com>
Date:	Tue, 30 Mar 2010 16:15:48 +0300
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	Andreas Henriksson <andreas@...al.se>
Cc:	Patrick McHardy <kaber@...sh.net>,
	Stephen Hemminger <shemminger@...tta.com>,
	jamal <hadi@...erus.ca>, netdev@...r.kernel.org
Subject: Re: XT_ALIGN changed to use ALIGN breaks iproute2

On Tue, Mar 30, 2010 at 12:28 PM, Andreas Henriksson <andreas@...al.se> wrote:
> You updated the kernel header include/linux/netfilter/x_tables.h
> in torvalds/linux-2.6.git commit 42107f5009da223daa800d6da6904d77297ae829
> with the comment "Use ALIGN() macro while I'm at it for same types.".
>
> When this header was synced into iproute2 the build broke because the
> ALIGN macro apparently only is defined in kernel headers.
>
> (For iproute2 the problem was introduced in
> 8ecdcce08319d0e39b0d32c1d17db3f69d85a35c and found by Stephen
> and worked around in 609ceb807deba8e23 and edaaa11e5a3cf2c9c1a39)
>
> I'm guessing the problem in the iproute2 header sync is just a heads
> up for what's going to happen when distributions updates their
> system headers to match linux 2.6.33.
>
>
> Could someone who knows how the userspace version of the kernel
> headers are generated please find a suitable solution?

We can export ALIGN to userspace, but the name is so generic,
so it's not clear what breakage more risky.

XT_ALIGN is a macro so breakage will appear only when it's used,
not when header is included directly or indirectly.

We have tc, iptables, both carry their own copy of headers, what else?

Right now, I'd say, do nothing, and iptables will carry fixlet as in tc,
eventually.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html