[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20100331160811.16351eb7@s6510>
Date: Wed, 31 Mar 2010 16:08:11 -0700
From: Stephen Hemminger <shemminger@...tta.com>
To: James Chapman <jchapman@...alix.com>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH v3 04/12] l2tp: Add ppp device name to L2TP ppp session
data
On Wed, 31 Mar 2010 08:43:09 +0100
James Chapman <jchapman@...alix.com> wrote:
> Stephen Hemminger wrote:
> > On Tue, 30 Mar 2010 17:17:46 +0100
> > James Chapman <jchapman@...alix.com> wrote:
> >
> >> When dumping L2TP PPP sessions using /proc/net/l2tp, get
> >> the assigned PPP device name from PPP using ppp_dev_name().
> >>
> >> Signed-off-by: James Chapman <jchapman@...alix.com>
> >> Reviewed-by: Randy Dunlap <randy.dunlap@...cle.com>
> >>
> >
> > Why is this a necessary API?
> > Why not put it in debugfs if just a debugging tool?
>
> With the original driver (merged in 2.6.23), some people use horrible
> hacks in scripts to derive info about their L2TP connections from /proc.
> So I was reluctant to move it to debugfs in the new driver. If it is ok
> to move an existing /proc file to debugfs, I'm happy to do so. People
> should obtain such info from their L2TP userspace daemon, or through
> netlink anyway.
>
>
Sounds like a good use of sysfs either with attribute or symlink
back to underlying device
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists