netdev - RE: re-submit2 [ANNOUNCEMENT] NET: usb: sierra

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1270077969.8653.491.camel@localhost>
Date:	Thu, 01 Apr 2010 00:26:09 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Elina Pasheva <epasheva@...rrawireless.com>
Cc:	davem@...emloft.net, Rory Filer <rfiler@...rrawireless.com>,
	"dbrownell@...rs.sourceforge.net" <dbrownell@...rs.sourceforge.net>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: re-submit2 [ANNOUNCEMENT] NET: usb: sierra_net.c driver

On Wed, 2010-03-31 at 13:58 -0700, Elina Pasheva wrote:
> On Tue, 2010-03-30 at 23:21 -0700, Rory Filer wrote:
> > -----Original Message-----
> > > >
> > > > Applied, thanks.
> > > 
> > > Nevermind, reverted, it doesn't even build.
> > > 
> > > drivers/net/usb/sierra_net.c: In function 'check_ethip_packet':
> > > drivers/net/usb/sierra_net.c:221:3: error: implicit declaration of
> > > function 'deverr'
> > > 
> > > Really, this should never ever happen, and there is simply
> > > no excuse at all for this.
> > 
> > Well actually there is an excuse, but I'm sure you don't want to
> > know what it is. 
> 
> The patch was posted saying it had only been tested on 2.6.33.1.
> There was failure-to-build and boot problems  beyond our control with 2.6.34-rc2.
> Now that 2.6.34-rc3 is available (and we are able to build and boot on our Ubuntu platform)
> I will modify the driver to reflect the fact that deverr is no longer in existence
> and is replaced by another function. I will submit the modified driver tested on 2.6.34-rc3 shortly.

You should be sending patches based on David Miller's net-next-2.6 or
net-2.6 git repository, where he will be applying them.  As this is a
new driver I assume it can go into net-2.6.

> Perhaps we should have waited until the build problem was fixed.

Or come up with a fix yourself.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html