lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20100331004259.GA9977@gondor.apana.org.au> Date: Wed, 31 Mar 2010 08:43:00 +0800 From: Herbert Xu <herbert@...dor.apana.org.au> To: Timo Teräs <timo.teras@....fi> Cc: netdev@...r.kernel.org Subject: Re: [PATCH 1/7] xfrm: remove policy lock when accessing policy->walk.dead On Tue, Mar 30, 2010 at 06:36:37PM +0300, Timo Teräs wrote: > > I only added it because it's non-trivial to figure out if there's > any code path that could race. It's a great help for reader of the > code to see that it's correct even if it's not strictly needed. No that's bad because you're misleading people into thinking something that isn't allowed can happen. It's much better to add a comment instead. > I will also include a patch to fix the missing 'dir' check in > xfrm_user. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists