netdev - Re: [PATCH 1/6] cxgb4: Add register, message, and FW definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4BB2A4A4.8050904@chelsio.com>
Date:	Tue, 30 Mar 2010 18:25:56 -0700
From:	Dimitris Michailidis <dm@...lsio.com>
To:	Stephen Hemminger <shemminger@...tta.com>
CC:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/6] cxgb4: Add register, message, and FW definitions

Stephen Hemminger wrote:
> On Tue, 30 Mar 2010 10:52:17 -0800
> Dimitris Michailidis <dm@...lsio.com> wrote:
> 
>> +union opcode_tid {
>> +	__be32 opcode_tid;
>> +	__u8 opcode;
>> +};
>> +
> 
> The intent of the __types like __u8 etc are that these types
> should only be used by structures that are part in some way of
> a kernel to userspace API. Any structures which are only used
> in the kernel should just use the regular type (ie u8).
> 
> I say intent because many places do not follow this practice.
> 

These headers aren't meant to be seen by user space and I can certainly 
replace __u8 with u8.  I'll update the patch.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html