netdev - Re: [PATCH] xtables: make XT_ALIGN() usable in exported headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4BB490B5.1040200@yoshifuji.org>
Date:	Thu, 01 Apr 2010 21:25:25 +0900
From:	"YOSHIFUJI Hideaki (吉藤 英明)" 
	<hideaki@...hifuji.org>
To:	Patrick McHardy <kaber@...sh.net>
CC:	Alexey Dobriyan <adobriyan@...il.com>,
	Stephen Hemminger <shemminger@...tta.com>,
	Ben Hutchings <bhutchings@...arflare.com>,
	Andreas Henriksson <andreas@...al.se>, jamal <hadi@...erus.ca>,
	netdev@...r.kernel.org
Subject: Re: [PATCH] xtables: make XT_ALIGN() usable in exported headers

I think it is better to solicit comments on LKML.

This is not a new issue but rather a common one
(e.g. CMSG_ALIGN uses its own definition).

Regards,

--yoshfuji

(2010/04/01 21:06), Patrick McHardy wrote:
> Alexey Dobriyan wrote:
>> On Thu, Apr 1, 2010 at 1:50 PM, Patrick McHardy<kaber@...sh.net>  wrote:
>>> I can't think of anything but to restore the XT_ALIGN macro.
>>> We could add a XT_ALIGN definition to xtables.h, but that might
>>> still leave problems for other users.
>>>
>>> Alexey, do you have any better suggestions?
>>
>> I like __KERNEL_ALIGN trick.
>>
>> Sorry for attachment, my patch sending facility is broke.
>> Tested on iptables compilation.
>>
>
> Seems fine to me, thanks. I'll wait a bit for others to comment.
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html