netdev - Re: [PATCH] rfs: Receive Flow Steering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1270211871.11099.2.camel@edumazet-laptop>
Date:	Fri, 02 Apr 2010 14:37:51 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Tom Herbert <therbert@...gle.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH] rfs: Receive Flow Steering


> > +static inline void rps_record_sock_flow(struct rps_sock_flow_table *table,
> > +					u32 hash)
> > +{
> 
> Hmm, so rps_record_sock_flow() is always called from non preemptable
> contextes ?
> 
> > +	rps_set_sock_flow(table, hash, smp_processor_id());
> > +}
> > +

I had to change this to :

static inline void rps_record_sock_flow(struct rps_sock_flow_table *table, u32 hash)
{
	/* we only give a hint, preemption can change our cpu under us */
	rps_set_sock_flow(table, hash, raw_smp_processor_id());
}



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html