netdev - Re: [PATCH] netlabel: Fix several rcu_dereference() calls used without RCU read locks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100401.172721.144384691.davem@davemloft.net>
Date:	Thu, 01 Apr 2010 17:27:21 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	paul.moore@...com, netdev@...r.kernel.org,
	paulmck@...ux.vnet.ibm.com
Subject: Re: [PATCH] netlabel: Fix several rcu_dereference() calls used
 without RCU read locks

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 01 Apr 2010 22:56:47 +0200

> Le jeudi 01 avril 2010 à 16:43 -0400, Paul Moore a écrit :
>> The recent changes to add RCU lock verification to rcu_dereference() calls
>> caught out a problem with netlbl_unlhsh_hash(), see below.
>> 
>>  ===================================================
>>  [ INFO: suspicious rcu_dereference_check() usage. ]
>>  ---------------------------------------------------
>>  net/netlabel/netlabel_unlabeled.c:246 invoked rcu_dereference_check()
>>  without protection!
>> 
>> This patch fixes this problem as well as others like it in the NetLabel
>> code.  Also included in this patch is the identification of future work
>> to eliminate the RCU read lock in netlbl_domhsh_add(), but in the interest
>> of getting this patch out quickly that work will happen in another patch
>> to be finished later.
>> 
>> Thanks to Eric Dumazet and Paul McKenney for their help in understanding
>> the recent RCU changes.
>> 
>> Signed-off-by: Paul Moore <paul.moore@...com>
>> Reported-by: David Howells <dhowells@...hat.com>
>> CC: Eric Dumazet <eric.dumazet@...il.com>
>> CC: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
>> ---
>>  net/netlabel/netlabel_domainhash.c |   28 ++++++++++-----
>>  net/netlabel/netlabel_unlabeled.c  |   66 ++++++++++--------------------------
>>  2 files changed, 37 insertions(+), 57 deletions(-)
>> 
> 
> Acked-by: Eric Dumazet <eric.dumazet@...il.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html