netdev - Re: Undefined behaviour of connect(fd, NULL, 0);

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100405.122554.232915662.davem@davemloft.net>
Date:	Mon, 05 Apr 2010 12:25:54 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	xiaosuo@...il.com
Cc:	neilb@...e.de, shemminger@...tta.com, netdev@...r.kernel.org
Subject: Re: Undefined behaviour of connect(fd, NULL, 0);

From: Changli Gao <xiaosuo@...il.com>
Date: Mon, 5 Apr 2010 17:23:50 +0800

> I found this from the man page of FreeBSD's connect(2).
> 
>      Generally, stream sockets may successfully connect() only
>      once; datagram sockets may use connect() multiple times to change their
>      association.  Datagram sockets may dissolve the association by connecting
>      to an invalid address, such as a null address.
> 
> And this from the man page of Darwin's connect(2).
> 
>      Datagram sockets may dissolve the association by connecting to an
>      invalid address, such as a null address or an address with the address
>      family set to AF_UNSPEC (the error EAFNOSUPPORT will be harmlessly
>      returned).
> 
> Since null address behavior has been defined by the others. I think
> Linux should be compatible with the others. So the  patch submitted on
> this by me should not been applied. I'll work out another patch later.

Your patch is already applied and pushed out to the world.
Any corrections would need to be made relative to that.

But I think no changes should be made, and it doesn't matter
at all what some manual page says on another system.

It doesn't matter one iota what those paragraphs say, we've had the
existing behavior for FIFTEEN YEARS.  So, like I said last time, any
application coding to this behavior of the zero length sockaddr doing
anything on connect() will NOT WORK ON ANY KERNEL.

So supporting it has absolutely zero value, for us and for app
developers.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html