lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <z2m412e6f7f1004051523p6198556ak3e2ab9a52a3167d4@mail.gmail.com> Date: Tue, 6 Apr 2010 06:23:57 +0800 From: Changli Gao <xiaosuo@...il.com> To: Tom Herbert <therbert@...gle.com> Cc: davem@...emloft.net, netdev@...r.kernel.org Subject: Re: [PATCH] rps: fixed missed rps_unlock On Tue, Apr 6, 2010 at 5:30 AM, Tom Herbert <therbert@...gle.com> wrote: > Fix spin_unlock_irq which needs to be rps_unlock. > > Signed-off-by: Tom Herbert <therbert@...gle.com> > --- > diff --git a/net/core/dev.c b/net/core/dev.c > index 2a9b7dd..74f77ca 100644 > --- a/net/core/dev.c > +++ b/net/core/dev.c > @@ -3120,7 +3120,7 @@ static int process_backlog(struct napi_struct *napi, int quota) > skb = __skb_dequeue(&queue->input_pkt_queue); > if (!skb) { > __napi_complete(napi); > - spin_unlock_irq(&queue->input_pkt_queue.lock); > + rps_unlock(queue); > break; > } > rps_unlock(queue); It seems that irq isn't enabled when breaking the loop. Please add local_irq_enable(); after rps_unlock(queue); -- Regards, Changli Gao(xiaosuo@...il.com) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists