netdev - Re: [RFC PATCH 1/2] netdev: buffer infrastructure to log network driver's information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100406001034.GA2156@localhost.localdomain>
Date:	Mon, 5 Apr 2010 20:10:34 -0400
From:	Neil Horman <nhorman@...driver.com>
To:	David Miller <davem@...emloft.net>
Cc:	eric.dumazet@...il.com, sanagi.koki@...fujitsu.com,
	netdev@...r.kernel.org, izumi.taku@...fujitsu.com,
	kaneshige.kenji@...fujitsu.com, jeffrey.t.kirsher@...el.com,
	jesse.brandeburg@...el.com, bruce.w.allan@...el.com,
	alexander.h.duyck@...el.com, peter.p.waskiewicz.jr@...el.com,
	john.ronciak@...el.com
Subject: Re: [RFC PATCH 1/2] netdev: buffer infrastructure to log network
 driver's information

On Mon, Apr 05, 2010 at 12:31:55PM -0700, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@...il.com>
> Date: Mon, 05 Apr 2010 10:42:26 +0200
> 
> > Le lundi 05 avril 2010 à 15:52 +0900, Koki Sanagi a écrit :
> >> This patch implements buffer infrastructure under driver/net.
> >> This buffer records information from network driver.
> >> 
> >> Signed-off-by: Koki Sanagi <sanagi.koki@...fujitsu.com>
> >> ---
> >>   drivers/net/Kconfig     |    8 +
> >>   drivers/net/Makefile    |    1 +
> >>   drivers/net/ndrvbuf.c   |  535 +++++++++++++++++++++++++++++++++++++++++++++++
> >>   include/linux/ndrvbuf.h |   57 +++++
> >>   4 files changed, 601 insertions(+), 0 deletions(-)
> >> 
> > 
> > Wow, 600 lines... thats what I call bloat...
> 
> And we have all sorts of facilities for creating filesystem
> streams and ring buffers of debug information.
> 
> You could even hook into 'perf' to log and process these
> events in probably like 12 lines of code.
> 
I'm still having a hard time understanding why this approach is preferable to
the previous approach you took using tracepoints.  Granted you can't get driver
internal state as easily, but its generic and doesn't do...this.
Neil

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html