| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <v2jd45a3acc1004060509u88f32fa1va0c374154806535b@mail.gmail.com> Date: Tue, 6 Apr 2010 22:09:10 +1000 From: andrew hendry <andrew.hendry@...il.com> To: John Hughes <john@...va.com> Cc: netdev@...r.kernel.org Subject: Re: patch to improve x.25 throughput negotiation I have reproduced a few ways. 1. X25_MASK_THROUGHPUT on the x25_subscript_struct, then call SIOCX25SSUBSCRIP, then call SIOCX25FACILITIES without setting the throughput field. Call connect. 2. No subscrip setting, call SIOCX25FACILITIES without setting the throughput field. Call connect. 3. No subcrip, no facilities ioctl, call connect. The patch removes the bad facility and makes the router accept the call for the above cases. I don't currently have a setup to test both direction throughput negotiation. Tested-by: Andrew Hendry <andrew.hendry@...il.com> On Mon, Apr 5, 2010 at 2:48 AM, John Hughes <john@...va.com> wrote: > The current X.25 code has some bugs in throughput negotiation: > > 1. It does negotiation in all cases, usually there is no need > 2. It incorrectly attempts to negotiate the throughput class in one > direction only. There are separate throughput classes for input > and output and if either is negotiated both mist be negotiates. > > This is bug https://bugzilla.kernel.org/show_bug.cgi?id=15681 > > This bug was first reported by Daniel Ferenci to the linux-x25 mailing list > on 6/8/2004, but is still present. > > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists