netdev - Re: [PATCH] r6040: fix r6040_multicast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100407.165109.212914225.davem@davemloft.net>
Date:	Wed, 07 Apr 2010 16:51:09 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	florian@...nwrt.org
Cc:	netdev@...r.kernel.org, darkadept@...peed.ch
Subject: Re: [PATCH] r6040: fix r6040_multicast_list

From: Florian Fainelli <florian@...nwrt.org>
Date: Wed, 7 Apr 2010 13:18:48 +0200

> As reported in <https://bugzilla.kernel.org/show_bug.cgi?id=15355>, r6040_
> multicast_list currently crashes. This is due a wrong maximum of multicast
> entries. This patch fixes the following issues with multicast:
> 
> - number of maximum entries if off-by-one (4 instead of 3)
> 
> - the writing of the hash table index is not necessary and leads to invalid
> values being written into the MCR1 register, so the MAC is simply put in a non
> coherent state
> 
> - when we exceed the maximum number of mutlticast address, writing the
> broadcast address should be done in registers MID_1{L,M,H} instead of
> MID_O{L,M,H}, otherwise we would loose the adapter's MAC address
> 
> Signed-off-by: Florian Fainelli <florian@...nwrt.org>

Applied, thanks Florian.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html