netdev - Re: [PATCH] xfrm: Fix double dst_release() in xfrm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100408134331.GC30647@rakim.wolfsonmicro.main>
Date:	Thu, 8 Apr 2010 14:43:31 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Timo Teräs <timo.teras@....fi>
Cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] xfrm: Fix double dst_release() in xfrm_lookup()
 -EREMOTE case

On Thu, Apr 08, 2010 at 03:39:38PM +0300, Timo Teräs wrote:
> Mark Brown wrote:

> >I'm not sure if this is correct or not - there may a reference been
> >taken earlier in __xfrm_lookup() that's being dropped but I didn't spot
> >it.

> This is not correct.

So I was correct when I said that there might've been a reference taken
earlier :)

> This semantics is important because __xfrm_lookup() is also called
> from other places, that do other things when they get -EREMOTE.

Right, it was the fact that this was the only place doing the free that
made this unclear.  Some comments might make this rather more obvious,
the fact that the release was added to __xfrm_lookup() as part of the
recent patch made it unclear if the release that was still there in
xfrm_lookup() was still needed or an oversight.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html