netdev - RE: linux-next: build failure after merge of the final tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 8 Apr 2010 08:15:12 -0600
From:	John Linn <John.Linn@...inx.com>
To:	"David Miller" <davem@...emloft.net>, <sfr@...b.auug.org.au>
CC:	<netdev@...r.kernel.org>, <linux-next@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <jtyner@...ucr.edu>,
	<grant.likely@...retlab.ca>
Subject: RE: linux-next: build failure after merge of the final tree

> -----Original Message-----
> From: David Miller [mailto:davem@...emloft.net]
> Sent: Thursday, April 08, 2010 12:25 AM
> To: sfr@...b.auug.org.au
> Cc: netdev@...r.kernel.org; linux-next@...r.kernel.org;
linux-kernel@...r.kernel.org; John Linn;
> jtyner@...ucr.edu
> Subject: Re: linux-next: build failure after merge of the final tree
> 
> From: Stephen Rothwell <sfr@...b.auug.org.au>
> Date: Thu, 8 Apr 2010 15:35:05 +1000
> 
> > After merging the final tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> >
> > drivers/net/ll_temac_main.c: In function 'll_temac_recv':
> > drivers/net/ll_temac_main.c:695: error: implicit declaration of
function 'virt_to_bus'
> >
> > Caused by commit 459569145516f7967b916c57445feb02c600668c ("Add
> > non-Virtex5 support for LL TEMAC driver") from the net tree.
> >
> > I have reverted that commit for today.
> 
> And I'm reverting it too, it's illegal to use virt_to_bus()
> in new code in this day and age.

I'm not pushing back here, just trying to make sure I understand and do
it better next time :)

I don't see that my patch has touched that part of the driver as that
call was already in the driver before my patch (but maybe I'm just
missing it).

My patch did change the dependency in the Kconfig so that it only
depends on powerpc rather than powerpc DCR and maybe that exposed
something that wasn't previously exposed.

Maybe this is an issue in linux-next and I need to test against that,
I'm pulling it now.  I was testing against Linus's tree.

> 
> John, you'll need to use the DMA mapping APIs in this change when you
> resubmit it.

Thanks, will spin it again and get that fixed.  My apologies for the
hassles, appreciate the help.

-- John

> 
> Thanks.

This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html