netdev - Re: [PATCH] udp: fix for unicast RX path optimization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1270739547.2215.61.camel@edumazet-laptop>
Date:	Thu, 08 Apr 2010 17:12:27 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	jorge@...2.net, David Miller <davem@...emloft.net>
Cc:	Linux Network Development list <netdev@...r.kernel.org>
Subject: Re: [PATCH] udp: fix for unicast RX path optimization

Le jeudi 08 avril 2010 à 16:56 +0200, Jorge Boncompte [DTI2] a écrit :
> 	Commits 5051ebd275de672b807c28d93002c2fb0514a3c9 and
> 5051ebd275de672b807c28d93002c2fb0514a3c9 ("ipv[46]: udp: optimize unicast RX
> path") broke some programs.
> 
> 	After upgrading a L2TP server to 2.6.33 it started to fail, tunnels going up an
> down, after the 10th tunnel came up. My modified rp-l2tp uses a global
> unconnected socket bound to (INADDR_ANY, 1701) and one connected socket per
> tunnel after parameter negotiation.
> 
> 	After ten sockets were open and due to mixed parameters to
> udp[46]_lib_lookup2() kernel started to drop packets.
> 
> Signed-off-by: Jorge Boncompte [DTI2] <jorge@...2.net>

Oops...

Thank you for finding this bug, this is indeed the right fix.

This is a stable candidate. David, can you catch it even if Jorge didnt
sent you a copy ?

Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html