netdev - Re: [net-next-2.6 PATCH] igb: add support for reporting 5GT/s during probe on PCIe Gen2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1270857256.2176.37.camel@localhost>
Date:	Sat, 10 Apr 2010 00:54:16 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, gospo@...hat.com,
	Alexander Duyck <alexander.h.duyck@...el.com>
Subject: Re: [net-next-2.6 PATCH] igb: add support for reporting 5GT/s
 during probe on PCIe Gen2

On Fri, 2010-04-09 at 12:52 -0700, Jeff Kirsher wrote:
> From: Alexander Duyck <alexander.h.duyck@...el.com>
> 
> This change corrects the fact that we were not reporting Gen2 link speeds
> when we were in fact connected at Gen2 rates.
> 
> Signed-off-by: Alexander Duyck <alexander.h.duyck@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> ---
> 
>  drivers/net/igb/e1000_defines.h |    3 +++
>  drivers/net/igb/e1000_mac.c     |   19 ++++++++++++++++---
>  drivers/net/igb/igb_main.c      |    1 +
>  3 files changed, 20 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/igb/e1000_defines.h b/drivers/net/igb/e1000_defines.h
> index 31d24e0..8e440e8 100644
> --- a/drivers/net/igb/e1000_defines.h
> +++ b/drivers/net/igb/e1000_defines.h
> @@ -615,6 +615,9 @@
>  
>  #define PCIE_LINK_WIDTH_MASK         0x3F0
>  #define PCIE_LINK_WIDTH_SHIFT        4
> +#define PCIE_LINK_SPEED_MASK         0x0F
> +#define PCIE_LINK_SPEED_2500         0x01
> +#define PCIE_LINK_SPEED_5000         0x02
>  #define PCIE_DEVICE_CONTROL2_16ms    0x0005
[...]

These generic definitions belong in <linux/pci_regs.h>; in fact some of
it is already there.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html