lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 12 Apr 2010 20:35:36 +0100 From: Russell King - ARM Linux <linux@....linux.org.uk> To: FUJITA Tomonori <fujita.tomonori@....ntt.co.jp> Cc: linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org, davem@...emloft.net, linux-kernel@...r.kernel.org Subject: Re: [PATCH] ARM: dmabounce: fix partial sync in dma_sync_single_* API On Mon, Apr 05, 2010 at 12:39:32PM +0900, FUJITA Tomonori wrote: > I don't have arm hardware that uses dmabounce so I can't confirm the > problem but seems that dmabounce doesn't work for some drivers... Patch reviews fine, except for one niggle. I too don't have hardware I can test (well, I do except the kernel stopped supporting the UDA1341 audio codec on the SA1110 Neponset.) > @@ -171,10 +172,17 @@ find_safe_buffer(struct dmabounce_device_info *device_info, dma_addr_t safe_dma_ > read_lock_irqsave(&device_info->lock, flags); > > list_for_each_entry(b, &device_info->safe_buffers, node) > - if (b->safe_dma_addr == safe_dma_addr) { > - rb = b; > - break; > - } > + if (for_sync) { > + if (b->safe_dma_addr <= safe_dma_addr && > + safe_dma_addr < b->safe_dma_addr + b->size) { > + rb = b; > + break; > + } > + } else > + if (b->safe_dma_addr == safe_dma_addr) { > + rb = b; > + break; > + } This is the niggle; I don't like this indentation style. If you want to indent this if () statement, then please format like this: } else { if (b->safe...) { ... } } or format it as: } else if (b->safe...) { ... } -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists