netdev - Re: [PATCH] Fix some #includes in CAN drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100413.013614.200995710.davem@davemloft.net>
Date:	Tue, 13 Apr 2010 01:36:14 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	hjk@...utronix.de
Cc:	socketcan-core@...ts.berlios.de, netdev@...r.kernel.org,
	kernel@...gutronix.de, 21cnbao@...il.com, celston@...alix.com,
	chripell@...lware.org, wg@...ndegger.com, haas@...-wuenche.com,
	per.dalen@....se, P.B.Cheblakov@....nsk.su,
	oliver.hartkopp@...kswagen.de, anantgole@...com
Subject: Re: [PATCH] Fix some #includes in CAN drivers

From: "Hans J. Koch" <hjk@...utronix.de>
Date: Thu, 8 Apr 2010 21:25:45 +0200

> In the current implementation, CAN drivers need to #include <linux/can.h>
> _before_ they #include <linux/can/dev.h>, which is both ugly and
> unnecessary.
> 
> Fix this by including <linux/can.h> in <linux/can/dev.h> and remove the
> #include <linux/can.h> lines from drivers.
> 
> Signed-off-by: Hans J. Koch <hjk@...utronix.de>

This doesn't apply cleanly to net-next-2.6, please respin your patch
and resubmit.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html