netdev - Re: [PATCH 2/2] bcm63xx_enet: do not overwrite ENET_CTL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100413.033030.144455634.davem@davemloft.net>
Date:	Tue, 13 Apr 2010 03:30:30 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ffainelli@...ebox.fr
Cc:	netdev@...r.kernel.org, mbizon@...ebox.fr
Subject: Re: [PATCH 2/2] bcm63xx_enet: do not overwrite ENET_CTL_REG value

From: Florian Fainelli <ffainelli@...ebox.fr>
Date: Fri, 9 Apr 2010 13:04:52 +0200

> bcm_enet_hw_preinit will correctly set values in ENET_CTL_REG for internal
> or external MII operations, however, bcm_enet_open will blindly overwrite the
> ENET_CTL_REG register value and thus we will loose any changes to it that
> were made in bcm_enet_hw_preinit, rendering external MII operations non-working.
> 
> This would lead to the driver not being able to check for link availability on
> external PHY setups, and thus we would never get to sending packets because
> link was down from the driver side.
> 
> This was completely un-noticed because all boards out there but BCM6338-based
> ones use internal phy on their enet0 interface.
> 
> Signed-off-by: Florian Fainelli <ffainelli@...ebox.fr>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html