netdev - Re: [RFC PATCH 7/9] ipv4: ipmr: convert struct mfc_cache to struct list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100413.041506.177518126.davem@davemloft.net>
Date:	Tue, 13 Apr 2010 04:15:06 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	kaber@...sh.net
Cc:	netdev@...r.kernel.org
Subject: Re: [RFC PATCH 7/9] ipv4: ipmr: convert struct mfc_cache to struct
 list_head

From: kaber@...sh.net
Date: Sun, 11 Apr 2010 19:37:13 +0200

> From: Patrick McHardy <kaber@...sh.net>
> 
> Signed-off-by: Patrick McHardy <kaber@...sh.net>

Great, it looks like you didn't fall into most of the
traps that usually occur during a list_head conversion :-)

But:

> -		c->next = net->ipv4.mfc_unres_queue;
> -		net->ipv4.mfc_unres_queue = c;
> +		list_add_tail(&c->list, &net->ipv4.mfc_unres_queue);
 ...
>  	write_lock_bh(&mrt_lock);
> -	c->next = net->ipv4.mfc_cache_array[line];
> -	net->ipv4.mfc_cache_array[line] = c;
> +	list_add_tail(&c->list, &net->ipv4.mfc_cache_array[line]);
>  	write_unlock_bh(&mrt_lock);

Are you sure we mean to insert to the tail here?  It looks like a head
insertion to me beforehand, and the fact that the previous list
iterators start at the list head pointer seem to confirm this.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html