netdev - Re: [PATCH] Infiniband: Randomize local port allocation.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4BC546CF.9020004@redhat.com>
Date:	Wed, 14 Apr 2010 12:38:39 +0800
From:	Cong Wang <amwang@...hat.com>
To:	penguin-kernel@...ove.sakura.ne.jp
CC:	rolandd@...co.com, sean.hefty@...el.com, opurdila@...acom.com,
	eric.dumazet@...il.com, netdev@...r.kernel.org,
	nhorman@...driver.com, davem@...emloft.net, ebiederm@...ssion.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Infiniband: Randomize local port allocation.

penguin-kernel@...ove.sakura.ne.jp wrote:
> Sean Hefty wrote:
>> Sean and Roland, is below patch correct?
>>> inet_is_reserved_local_port() is the new function proposed in this patchset.
>> It looks correct to me.  I didn't test the patch series, but if I comment out
>> the call to inet_is_reserved_local_port() in the provided below, the changes
>> worked fine for me.
>>
>> Acked-by: Sean Hefty <sean.hefty@...el.com>
>>
> Thank you for testing.
> 
> I think it is better to split this patch into
> 
> Part 1: Make cma_alloc_any_port() to use cma_alloc_port().
> 
> Part 2: Insert "!inet_is_reserved_local_port(rover) &&" line.
> 
> for future "git bisect".
> 

Right, thanks a lot for your work!

So, I will rebase my patch 3/3 on top of this patch. I hope someone
could take this one asap.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html