netdev - Re: [net-next-2.6 PATCH 2/2] net: replace ipfragok with skb->local

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100416064344.GA12412@gondor.apana.org.au>
Date:	Fri, 16 Apr 2010 14:43:44 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Shan Wei <shanwei@...fujitsu.com>
Cc:	David Miller <davem@...emloft.net>, yinghai.lu@...cle.com,
	kuznet@....inr.ac.ru, pekkas@...core.fi, jmorris@...ei.org,
	"yoshfuji@...ux-ipv6.org >> YOSHIFUJI Hideaki" 
	<yoshfuji@...ux-ipv6.org>, Patrick McHardy <kaber@...sh.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	dccp@...r.kernel.org, linux-sctp@...r.kernel.org,
	kleptog@...na.org, jchapman@...alix.com, mostrows@...akeasy.net,
	acme@...nectiva.com.br
Subject: Re: [net-next-2.6 PATCH 2/2] net: replace ipfragok with
	skb->local_df

On Fri, Apr 16, 2010 at 10:26:09AM +0800, Shan Wei wrote:
> 
> Now, PPPoX/PPPoL2TP driver still use ip_queue_xmit to send packets with ipfragok == 1.
> So, now we can't remove the && ... bit. 

Huh? If they still call ip_queue_xmit with ipfragok then surely
the build will fail after your patch as it removes the ipfragok
argument?

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html