lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 16 Apr 2010 23:57:34 +1000 (EST) From: Finn Thain <fthain@...egraphics.com.au> To: Joe Perches <joe@...ches.com> cc: David Miller <davem@...emloft.net>, p_gortmaker@...oo.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, linux-m68k@...r.kernel.org Subject: Re: [PATCH] mac8390: fix pr_info() calls and change return code On Thu, 15 Apr 2010, Joe Perches wrote: > ...Why is it better to use -EBUSY? Nubus slots are geographically addressed and their irqs are equally inflexible. -EAGAIN is misleading because retrying will not help fix whatever bug caused the irq to unavailable. > ...It'd be better to prefix this with the driver name > or use something like netdev_dbg with #define DEBUG > otherwise it's "huh? what device emits this message?" > when reading the logs. > > Something like: > printk(KERN_DEBUG pr_fmt("reset not supported\n")); Thanks for the suggestion. I'll resend again. > ...unnecessary conversion. I guess some prefer consistency, some prefer symmetry. Finn -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists