lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 20 Apr 2010 14:13:39 -0400 From: Brian Haley <brian.haley@...com> To: Jiri Olsa <jolsa@...hat.com> CC: davem@...emloft.net, kuznet@....inr.ac.ru, pekkas@...core.fi, jmorris@...ei.org, yoshfuji@...ux-ipv6.org, kaber@...sh.net, eric.dumazet@...il.com, netdev@...r.kernel.org Subject: Re: [PATCH] net: ipv6 bind to device issue Jiri Olsa wrote: > diff --git a/net/ipv6/route.c b/net/ipv6/route.c > index c2438e8..7bf7717 100644 > --- a/net/ipv6/route.c > +++ b/net/ipv6/route.c > @@ -815,7 +815,7 @@ struct dst_entry * ip6_route_output(struct net *net, struct sock *sk, > { > int flags = 0; > > - if (rt6_need_strict(&fl->fl6_dst)) > + if (rt6_need_strict(&fl->fl6_dst) || fl->oif) > flags |= RT6_LOOKUP_F_IFACE; > > if (!ipv6_addr_any(&fl->fl6_src)) Actually, looking at this again, we might want to swap the order here since fl->oif should be filled-in for most link-local and multicast requests calling this: if (fl->oif || rt6_need_strict(&fl->fl6_dst)) Just a thought, but it potentially saves a call to determine the scope of the address. -Brian -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists