netdev - Re: [PATCH] tg3: Fix INTx fallback when MSI fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100421.161751.94080129.davem@davemloft.net>
Date:	Wed, 21 Apr 2010 16:17:51 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	adetsch@...ibm.com
Cc:	netdev@...r.kernel.org, mcarlson@...adcom.com
Subject: Re: [PATCH] tg3: Fix INTx fallback when MSI fails

From: Andre Detsch <adetsch@...ibm.com>
Date: Fri, 16 Apr 2010 10:15:11 -0300

> tg3: Fix INTx fallback when MSI fails
> 
> MSI setup changes the value of some key attributes of struct tg3 *tp.
> These attributes must be taken into account and restored before
> we try to do a new request_irq for INTx fallback.
> 
> In powerpc, the original code was leading to an EINVAL return within
> request_irq, because the driver was trying to use the disabled MSI
> virtual irq number instead of tp->pdev->irq.
> 
> Signed-off-by: Andre Detsch <adetsch@...ibm.com>

Broadcom folks, please review, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html