netdev - Re: Subject: re-submit4 [ANNOUNCEMENT] NET: usb: sierra

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100422194435.GA14544@kroah.com>
Date:	Thu, 22 Apr 2010 12:44:35 -0700
From:	Greg KH <greg@...ah.com>
To:	Elina Pasheva <epasheva@...rrawireless.com>
Cc:	dbrownell@...rs.sourceforge.net, davem@...emloft.net,
	rfiler@...rrawireless.com, linux-usb@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: Subject: re-submit4 [ANNOUNCEMENT] NET: usb: sierra_net.c
 driver

On Thu, Apr 22, 2010 at 12:19:33PM -0700, Elina Pasheva wrote:
> +static void sierra_net_send_cmd(struct usbnet *dev,
> +		u8 *cmd, int cmdlen, const char * cmd_name)
> +{
> +	struct sierra_net_data *priv = sierra_net_get_private(dev);
> +	int  status;
> +
> +	status = usb_control_msg(dev->udev, usb_sndctrlpipe(dev->udev, 0),
> +			USB_CDC_SEND_ENCAPSULATED_COMMAND,
> +			USB_DIR_OUT|USB_TYPE_CLASS|USB_RECIP_INTERFACE,	0,
> +			priv->ifnum, cmd, cmdlen, 0);

No timeout?

> +		ifnum = priv->ifnum;
> +		len = usb_control_msg(dev->udev, usb_rcvctrlpipe(dev->udev, 0),
> +				USB_CDC_GET_ENCAPSULATED_RESPONSE,
> +				USB_DIR_IN|USB_TYPE_CLASS|USB_RECIP_INTERFACE,
> +				0, ifnum, buf, SIERRA_NET_USBCTL_BUF_LEN, 0);

No timeout?

> +		if (unlikely(len < 0)) {
> +			netdev_err(dev->net,
> +				"usb_control_msg failed, status %d\n", len);

You don't need "unlikely", this is an extreemly slow path here.
Also, what happens for a "short read"?  You don't handle that properly.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html