netdev - Re: [PATCH v2] rps: optimize rps_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100421.224014.77255834.davem@davemloft.net>
Date:	Wed, 21 Apr 2010 22:40:14 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	xiaosuo@...il.com
Cc:	therbert@...gle.com, eric.dumazet@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2] rps: optimize rps_get_cpu()

From: Changli Gao <xiaosuo@...il.com>
Date: Tue, 20 Apr 2010 22:02:40 +0800

> use ihl in bytes to eliminate later multiplyings.

I'll buy you a cookie if you can find a multiply generated by the
compiler for "x * 4".  It's going to use shifts and those are
basically free.

Please just change one thing at a time.  It would have helped you
here.  I was willing to apply the port dereference part of your
change, but not necessarily the 'ihl' changes.  But because you've
combined them, I have no choice but to reject everything.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html