netdev - Re: Subject: re-submit4 [ANNOUNCEMENT] NET: usb: sierra

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1271978208.12776.7.camel@Linuxdev4-laptop>
Date:	Thu, 22 Apr 2010 16:16:48 -0700
From:	Elina Pasheva <epasheva@...rrawireless.com>
To:	Greg KH <greg@...ah.com>
CC:	Dan Williams <dcbw@...hat.com>,
	"dbrownell@...rs.sourceforge.net" <dbrownell@...rs.sourceforge.net>,
	"davem@...emloft.net" <davem@...emloft.net>,
	Rory Filer <rfiler@...rraWireless.com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: Subject: re-submit4 [ANNOUNCEMENT] NET: usb: sierra_net.c
	driver

On Thu, 2010-04-22 at 15:27 -0700, Greg KH wrote:

> > > > +
> > > > +	status = usb_control_msg(dev->udev, usb_sndctrlpipe(dev->udev, 0),
> > > > +			USB_CDC_SEND_ENCAPSULATED_COMMAND,
> > > > +			USB_DIR_OUT|USB_TYPE_CLASS|USB_RECIP_INTERFACE,	0,
> > > > +			priv->ifnum, cmd, cmdlen, 0);
> > > 
> > > No timeout?
Good catch. Will fix.

> > > No timeout?
Will fix.
> > > 
> > > > +		if (unlikely(len < 0)) {
> > > > +			netdev_err(dev->net,
> > > > +				"usb_control_msg failed, status %d\n", len);
> > > 
> > > You don't need "unlikely", this is an extreemly slow path here.
Will fix.

> Well, if the return value is less than what you expect it to be,
> something went wrong and you should error out.  Some of the calls handle
> this properly in this driver, some do not.  Consistency is key :)
Good point. Thanks. Will check for consistency and resubmit.

Elina


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html