lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <alpine.OSX.2.00.1004221108270.289@localhost> Date: Thu, 22 Apr 2010 11:13:21 +1000 (EST) From: Finn Thain <fthain@...egraphics.com.au> To: David Miller <davem@...emloft.net> cc: joe@...ches.com, p_gortmaker@...oo.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, linux-m68k@...r.kernel.org Subject: Re: [PATCH] mac8390: change an error return code and some cleanup, take 3 On Wed, 21 Apr 2010, David Miller wrote: > From: Finn Thain <fthain@...egraphics.com.au> > Date: Sat, 17 Apr 2010 13:16:04 +1000 (EST) > > > > > Change an error return code from -EAGAIN to -EBUSY since the former is > > misleading. > > > > Nubus slots are geographically addressed and their irqs are equally > > inflexible. -EAGAIN is misleading because retrying will not help fix > > whatever bug it was that made the irq unavailable. > > request_irq() itself returns an appropriate error code, so the > correct change is to do: > > err = request_irq( ... ); > if (err) { > ... > > and return 'err'. OK. I'll send a new patch once 2.6.34 is out and I have time to test this and some other patches. Finn -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists