lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20100422.024336.119875321.davem@davemloft.net> Date: Thu, 22 Apr 2010 02:43:36 -0700 (PDT) From: David Miller <davem@...emloft.net> To: xiaosuo@...il.com Cc: hadi@...erus.ca, therbert@...gle.com, eric.dumazet@...il.com, netdev@...r.kernel.org Subject: Re: [PATCH v5] net: batch skb dequeueing from softnet input_pkt_queue From: Changli Gao <xiaosuo@...il.com> Date: Thu, 22 Apr 2010 17:09:17 +0800 > + unsigned int input_pkt_queue_len; > + struct sk_buff *input_pkt_queue_head; > + struct sk_buff **input_pkt_queue_tailp; > + Please do not ignore Stephen Hemminger's feedback. We already have enough odd SKB queue implementations, we do not need yet another one in a core location. This makes it harder and harder to eventually convert sk_buff to use "struct list_head". Instead, use "struct sk_buff_head" and the lockless accessors (__skb_insert, etc.) and initializer (__skb_queue_head_init). -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists