[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <4BD04B88.4000007@trash.net>
Date: Thu, 22 Apr 2010 15:13:44 +0200
From: Patrick McHardy <kaber@...sh.net>
To: Paul LeoNerd Evans <leonerd@...nerd.org.uk>
CC: netdev@...r.kernel.org
Subject: Re: [PATCH] Socket filter ancilliary data access for skb->dev->type
Paul LeoNerd Evans wrote:
> On Thu, Apr 22, 2010 at 02:28:46PM +0200, Patrick McHardy wrote:
>> I think we should be adding a check whether skb->dev is non-NULL here
>> since filters can also be attached to netlink sockets. The same applies
>> to SKF_AD_IFINDEX.
>
> What should the appropriate behaviour be here? Set A to some rogue value
> - 0 or -1 seem appropriate? Or, abort the filter entirely (such as in
> e.g. divide-by-zero, or invalid memory buffer access)?
>
> Either way that sounds simple enough, I can hack that in and resubmit.
I'd say we should abort execution.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists